[PATCH] D113341: [SystemZ] Support symbolic displacements.
Jonas Paulsson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 15 13:51:12 PST 2021
jonpa added inline comments.
================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmBackend.cpp:162
+ uint64_t DHi = (Value >> 12) & 0xff;
+ Value = (DLo << 8) | DHi;
+ }
----------------
uweigand wrote:
> I think it might be preferabe to do the bit-swapping **in** `extractBitsForFixup` - that routine is supposed to return the //bits// to be placed in the instruction slot.
ah, yes - makes sense...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113341/new/
https://reviews.llvm.org/D113341
More information about the llvm-commits
mailing list