[PATCH] D113935: [RISCV] Add test cases to prepare for overring TargetLowering::hasAndNot. NFC

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 13:31:50 PST 2021


lebedev.ri added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll:168
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+; Should be the same as the previous one.
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
----------------
craig.topper wrote:
> jrtc27 wrote:
> > I don't understand what this is referring to
> I think it was trying to say that we should transform each of the in* functions the equivalent of the corresponding out* test.
Yep. The `out` is the unmerged form of masked-merge, the `in` is merged form.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113935/new/

https://reviews.llvm.org/D113935



More information about the llvm-commits mailing list