[PATCH] D113894: [x86/asm] Make variants work when converting at&t inline asm input to intel asm output

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 13:30:15 PST 2021


thakis added a comment.

In D113894#3132622 <https://reviews.llvm.org/D113894#3132622>, @thakis wrote:

>> I thought `asm inteldialect` is used to select `EmitMSInlineAsmStr` in AsmPrinterInlineAsm.cpp. Is that also changing? Are the only differences between those functions related to the assembly syntax and not the originating C code?
>
> That's true, and that's not changing, at least that's my current plan. D113932 <https://reviews.llvm.org/D113932> is the last change in LLVM land I want to make in preparation for the clang change.

I've now uploaded an updated version of D113707 <https://reviews.llvm.org/D113707>, the clang change. Maybe looking at that makes it clearer how the three changes are related :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113894/new/

https://reviews.llvm.org/D113894



More information about the llvm-commits mailing list