[PATCH] D113935: [RISCV] Add test cases to prepare for overring TargetLowering::hasAndNot. NFC

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/selectcc-to-shiftand.ll:3
+; RUN: llc < %s -mtriple=riscv32 \
+; RUN:     | FileCheck %s --check-prefixes=CHECK,RV32,RV32I
+; RUN: llc < %s -mtriple=riscv64 \
----------------
I think we normally use a 2 space indent for this, not four?


================
Comment at: llvm/test/CodeGen/RISCV/selectcc-to-shiftand.ll:166
+
+; https://llvm.org/bugs/show_bug.cgi?id=31175
+
----------------
Maybe not useful for a RISC-V test? Though the fix for this is what introduced the TLI hook and was otherwise target-independent.


================
Comment at: llvm/test/CodeGen/RISCV/selectcc-to-shiftand.ll:169
+; ret = (x-y) > 0 ? x-y : 0
+define i32 @PR31175(i32 signext %x, i32 signext %y) {
+; RV32I-LABEL: PR31175:
----------------
Maybe wants a more informative name as a result? sub_clamp_zero or something similarly descriptive


================
Comment at: llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll:11
+
+; https://bugs.llvm.org/show_bug.cgi?id=37104
+
----------------
This one was filed against X86 but looks to have really been target-independent? Not sure if the bug link is worthwhile or not.


================
Comment at: llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll:168
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+; Should be the same as the previous one.
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
----------------
I don't understand what this is referring to


================
Comment at: llvm/test/CodeGen/RISCV/unfold-masked-merge-scalar-variablemask.ll:232
+}
+; ============================================================================ ;
+; Commutativity tests.
----------------
>From this point on there aren't blank lines around functions (and headers like this), it's all crammed together


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113935/new/

https://reviews.llvm.org/D113935