[PATCH] D113894: [x86] Make assembler variant selection work when outputting intel-style asm

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

> I thought `asm inteldialect` is used to select `EmitMSInlineAsmStr` in AsmPrinterInlineAsm.cpp. Is that also changing? Are the only differences between those functions related to the assembly syntax and not the originating C code?

That's true, and that's not changing, at least that's my current plan. D113932 <https://reviews.llvm.org/D113932> is the last change in LLVM land I want to make in preparation for the clang change.

The idea is that att style `__asm__` becomes `asm` and -masm=intel `__asm__` becomes `asm inteldialect`.

I'm not super duper familiar with the asm code (also not 100% unfamiliar though), so maybe there's some better way to handle this? But this approach seems to work well in my tests, seems to pass tests, and is fairly non-invasive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113894/new/

https://reviews.llvm.org/D113894