[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D98232#3132500 <https://reviews.llvm.org/D98232#3132500>, @qcolombet wrote:

>> should we go ahead and revert (most of*) https://reviews.llvm.org/D35816?
>
> Although I think that's the right approach, neither @aditya_nandakumar or I had time to clean up and push the fix for eviction chains yet.
>
> @aditya_nandakumar do you have an ETA when you believe you can land that?
> Should I just take over at this point?
>
> Cheers,
> -Quenitn

Ack - but I think the 2 are somewhat orthogonal; at this point, the old functionality is basically dead code (only exercised by a few tests), unless someone explicitly opts into it.  So what I was thinking was to send an email to llvm-dev and see if anyone explicitly passes `-mllvm -consider-local-interval-cost`. If not (the argument goes), let's yank out the old code. Then, later, Aditya's (or your) patch would come in on a clean slate.

Or does the envisioned patch require most of the stuff that's currently 'dead'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232