[PATCH] D113689: [llvm][ubsan] Inclusive language: replace use of blacklist HandleLLVMOptions.cmake

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:875
+    if (EXISTS "${IGNORELIST_FILE}")
+      append("-fsanitize-ignorelist=${IGNORELIST_FILE}"
              CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
ZarkoCA wrote:
> lebedev.ri wrote:
> > bjope wrote:
> > > Now I can't build llvm with ubsan, using an older version of clang, without getting lots of errors such as
> > >   `clang-13: error: unknown argument: '-fsanitize-ignorelist=/workspace/llvm/llvm-main-sanitize-ubsan/llvm/utils/sanitizers/ubsan_ignorelist.txt'`
> > > that seems a bit unfortunate (or are there different requirements on which compiler version that is needed when building llvm depending on if I enable sanitizers or not?).
> > If that isn't supported even in the last released version of llvm then please revert immediately.
> Reverted in `44a64afd43943ed6f47c37f61a6cd2e99c7287f3` sorry about this.
@lebedev.ri it looks like this option has been supported starting from Clang 13.0. Is that too new? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113689/new/

https://reviews.llvm.org/D113689