[PATCH] D113787: [llvm-reduce] keep terminator instructions during ReduceGlobalVars

Mon Nov 15 10:43:48 PST 2021

lebedev.ri added a comment.

In D113787#3132163 <https://reviews.llvm.org/D113787#3132163>, @dwightguth wrote:

> Sure, but it can also be used to reproduce a small test case for a program that was miscompiled. But it won't do that effectively if individual delta passes, when run, crash unnecessarily in uninteresting ways. If we make this change, you will be making the tool considerably less useful for minimizing programs that are miscompiled by the compiler.

I echo what @aeubanks said.

In D113787#3132160 <https://reviews.llvm.org/D113787#3132160>, @aeubanks wrote:

> llvm-reduce does not preserve semantics in any way at all, it's purely meant to create a small reproducer for some crash

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113787/new/

https://reviews.llvm.org/D113787