[PATCH] D113706: [flang] Allow implicit procedure pointers to associate with explicit procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld marked 2 inline comments as done.
PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Evaluate/tools.cpp:969
+    }
   } else {
     msg = "Procedure %s associated with incompatible procedure"
----------------
ekieri wrote:
> Nit: could be useful with a comment indicating that we have an "OK" path out of the function here, cf. ln 942.
> 
> It could also be useful if the error message mentioned which condition of 15.4.2.2 is violated. That would then apply to all checks through CanBeCalledViaImplicitInterface(), and I'd say it is better to land this patch first, and work on that as a follow-up (I could also help if you'd like). What do you think?
Thanks, @ekieri.

I added an "OK".  I also added a "TODO" to enhance our reporting for why procedures cannot be called via implicit interfaces.


================
Comment at: flang/test/Semantics/assign03.f90:174
 
   ! 10.2.2.4(4)
   subroutine s6
----------------
ekieri wrote:
> Nit: As you mention in the summary, these are additional tests for 10.2.2.4(3).
Thanks.

I added a comment saying this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113706/new/

https://reviews.llvm.org/D113706