[PATCH] D113912: [JITLink] Fix splitBlock if there are symbols span across the boundary

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 09:38:52 PST 2021


steven_wu created this revision.
steven_wu added reviewers: lhames, dexonsmith.
Herald added subscribers: ributzka, hiraditya.
steven_wu requested review of this revision.
Herald added a project: LLVM.

Fix `splitBlock` so that it can handle the case when the block being
split has symbols span across the split boundary. This is an error
case in general but for EHFrame splitting on macho platforms, there is an
anonymous symbol that marks the entire block. Current implementation
will leave a symbol that is out of bound of the underlying block. Fix
the problem by dropping such symbols when the block is split.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113912

Files:
  llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
  llvm/lib/ExecutionEngine/JITLink/EHFrameSupport.cpp
  llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
  llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
  llvm/unittests/ExecutionEngine/JITLink/LinkGraphTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113912.387300.patch
Type: text/x-patch
Size: 9332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211115/2a0829f0/attachment.bin>


More information about the llvm-commits mailing list