[PATCH] D113453: [RISCV][NFC] Refactor some rvv instructions' definition with foreach.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 09:33:57 PST 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:859
-def VLSE64_V : VStridedLoad<LSWidth64, "vlse64.v">,
-               VLSSched<32>;
-
----------------
jrtc27 wrote:
> jrtc27 wrote:
> > jacquesguan wrote:
> > > frasercrmck wrote:
> > > > This part is changing from `VLSSched<32>` to `VLSSched<64>`. I assume that 32 is a bug?
> > > Yes, I think so.
> > Drop the [NFC] from the commit subject then, as it's not true
> (and explicitly mention this functional change in the body)
Ah yes good catch. I agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113453/new/

https://reviews.llvm.org/D113453



More information about the llvm-commits mailing list