[PATCH] D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 09:24:21 PST 2021


nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:998
+  // Set the max cost if an MMA type is present (v256i1, v512i1).
+  if (isMMAType(Ty))
+    return InstructionCost::getMax();
----------------
Can you please explain why we don't want to do this check in the above condition?


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:1083
+  // Set the max cost if an MMA type is present (v256i1, v512i1).
+  if (isMMAType(Val))
+    return InstructionCost::getMax();
----------------
If we are exiting early, might as well do it before we do the ISD/Cost computations above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113900/new/

https://reviews.llvm.org/D113900



More information about the llvm-commits mailing list