[PATCH] D113704: [AIX][llvm-go] AIX linker does not recognize `-rpath`

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.

LGTM, with minor nit



================
Comment at: llvm/tools/llvm-go/llvm-go.go:100
 	if runtime.GOOS != "darwin" {
-		// OS X doesn't like -rpath with cgo. See:
-		// https://github.com/golang/go/issues/7293
-		ldflags = "-Wl,-rpath," + llvmConfig("--libdir") + " " + ldflags
+        if runtime.GOOS == "aix" {
+            // AIX linker does not honour `-rpath`, the closest substitution
----------------
nit: an if-elseif would be cleaner than the nested if here:
if runtime.GOOS == "aix" {
...
}
else if runtime.GOOS != "darwin" {
...
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113704/new/

https://reviews.llvm.org/D113704