[PATCH] D113887: [fir] Add fir.global_len conversion placeholder

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:648
+        globalLen, "fir.global_len codegen is not implemented yet");
+    return success();
+  }
----------------
kiranchandramohan wrote:
> clementval wrote:
> > awarzynski wrote:
> > > DELETEME
> > Thanks for catching this. 
> I think the select_type has a return failure which needs deletion.
You are right @kiranchandramohan. I'll remove it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113887/new/

https://reviews.llvm.org/D113887