[PATCH] D113648: Respect pgoff and rely on it for all types of binaries
Pavel Kosov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 15 06:14:39 PST 2021
kpdev42 added inline comments.
================
Comment at: lnt/testing/profile/cPerf.cpp:565
+ if (!(E->prot & PROT_EXEC))
+ break;
auto MapID = Maps.size();
----------------
DavidSpickett wrote:
> DavidSpickett wrote:
> > This has broken our armv7 LNT bot:
> > https://lab.llvm.org/buildbot/#/builders/174/builds/3548
> >
> > ```
> > lnt/testing/profile/cPerf.cpp: In member function ‘unsigned char* PerfReader::readEvent(unsigned char*)’:
> > lnt/testing/profile/cPerf.cpp:565:7: error: break statement not within loop or switch
> > 565 | break;
> > | ^~~~~
> > ```
> >
> > Perhaps you wanted to return?
> Just saw the fix come in, thanks!
Yes, something went wrong during rebase, fixed now. Thank you
Repository:
rLNT LNT
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113648/new/
https://reviews.llvm.org/D113648
More information about the llvm-commits
mailing list