[PATCH] D113756: [fir] Add fir.embox conversion

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 05:44:42 PST 2021


clementval added a comment.

> 2. `F18ADDENDUM` - it would be great to avoid `F18` (here and in other places). Perhaps `FLANG_ADDENDUM`?

The descriptor field is named `f18Addendum`. I think it's easier to follow if the name correspond to the name in code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113756/new/

https://reviews.llvm.org/D113756



More information about the llvm-commits mailing list