[PATCH] D113885: [MachineCSE] Use isAsCheapAsAMove in TargetInstrInfo

wangpc via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 04:49:02 PST 2021


pcwang-thead added a comment.

In D113885#3131136 <https://reviews.llvm.org/D113885#3131136>, @lkail wrote:

> IIUC, this shouldn't be an NFC change, please provide test cases.

I haven't found any cases, but I think it's obvious we should use the target dependent one.

The default implementation of `TargetInstrInfo.isAsCheapAsAMove` is just a call to `MachineInstr.isAsCheapAsAMove`, but targets for different archs may override it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113885/new/

https://reviews.llvm.org/D113885



More information about the llvm-commits mailing list