[PATCH] D100179: [GVN][NFC] Refactor code and add description for GVN object

Mon Nov 15 04:37:12 PST 2021

ksyx added a comment.

In D100179#3130694 <https://reviews.llvm.org/D100179#3130694>, @mstorsjo wrote:

> The bit that was split off and committed as rGc35e8185d8c170c20e28956e0c9f3c1be895fefb <https://reviews.llvm.org/rGc35e8185d8c170c20e28956e0c9f3c1be895fefb> was not an NFC, it broke compilation of one file for me: https://martin.st/temp/vlc-preproc.c
>
>   $ clang -target armv7-w64-mingw32 -w -c -O2 vlc-preproc.c 
>   clang: ../lib/Transforms/Utils/VNCoercion.cpp:475: llvm::Value* llvm::VNCoercion::getLoadValueForLoad(llvm::LoadInst*, unsigned int, llvm::Type*, llvm::Instruction*, const llvm::DataLayout&): Assertion `SrcVal-isSimple() && "Cannot widen volatile/atomic load!"' failed.
>
> I'd suggest reverting that patch until this issue is sorted out.

Thanks for your feedback! I am going to figure out that when I had time and I will revert it soon.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100179/new/

https://reviews.llvm.org/D100179