[PATCH] D113883: [fir] Add mlir::ComplexType conversion

Mon Nov 15 04:12:40 PST 2021

rovka added a comment.

In D113883#3131069 <https://reviews.llvm.org/D113883#3131069>, @kiranchandramohan wrote:

> In D113883#3131041 <https://reviews.llvm.org/D113883#3131041>, @kiranchandramohan wrote:
>
>> This might need a comment on why it is different from the regular mlir complex type conversion.
>
> I am guessing this is for the target-specific conversion which is not available in the regular mlir complex type conversion.

Good point. There's actually no target-specific conversion at this point, the target-specific parts are in the target-rewrite pass. I'm not sure why this conversion is needed here. Maybe @schweitz can explain.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113883/new/

https://reviews.llvm.org/D113883