[PATCH] D113756: [fir] Add fir.embox conversion

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1062
+                    ? mlir::cast<mlir::LLVM::LLVMFuncOp>(op)
+                    : op->getParentOfType<mlir::LLVM::LLVMFuncOp>();
+    rewriter.setInsertionPointToStart(&func.front());
----------------
rovka wrote:
> Do we really need op, or could we just replace all of this with 
> 
> ```
> auto func = thisBlock->getParentOfType<mlir::LLVM::LLVMFuncOp>() 
> ```
> ?
I think such a function does not exist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113756/new/

https://reviews.llvm.org/D113756