[PATCH] D113648: Respect pgoff and rely on it for all types of binaries

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 02:07:49 PST 2021


DavidSpickett added inline comments.


================
Comment at: lnt/testing/profile/cPerf.cpp:565
+    if (!(E->prot & PROT_EXEC))
+      break;
     auto MapID = Maps.size();
----------------
This has broken our armv7 LNT bot:
https://lab.llvm.org/buildbot/#/builders/174/builds/3548

```
lnt/testing/profile/cPerf.cpp: In member function ‘unsigned char* PerfReader::readEvent(unsigned char*)’:
lnt/testing/profile/cPerf.cpp:565:7: error: break statement not within loop or switch
  565 |       break;
      |       ^~~~~
```

Perhaps you wanted to return?


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113648/new/

https://reviews.llvm.org/D113648



More information about the llvm-commits mailing list