[PATCH] D113756: [fir] Add fir.embox conversion

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D113756#3127807 <https://reviews.llvm.org/D113756#3127807>, @awarzynski wrote:

> I've only managed to skim through -  will revisit next wekk.
>
> 1. I think that the overall readability of CodeGen.cpp could be improved if `EmboxCommonConversion` was separate from the other conversions (which tend to me compact and self-contained). Perhaps a dedicated file?

I would prefer to do this kind of file/code restructuring after the upstreaming is done. `EmboxCommonConversion` is (will be) used by other conversion pattern here. We already have such common struct for `ValueOpCommon`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113756/new/

https://reviews.llvm.org/D113756