[PATCH] D113769: [fir] !fir.tdesc type conversion

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 01:28:52 PST 2021


clementval updated this revision to Diff 387171.
clementval added a comment.

Rebase + add tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113769/new/

https://reviews.llvm.org/D113769

Files:
  flang/lib/Optimizer/CodeGen/TypeConverter.h
  flang/test/Fir/types-to-llvm.fir


Index: flang/test/Fir/types-to-llvm.fir
===================================================================
--- flang/test/Fir/types-to-llvm.fir
+++ flang/test/Fir/types-to-llvm.fir
@@ -301,3 +301,23 @@
 func private @foo0(%arg0: !fir.len)
 // CHECK-LABEL: foo0
 // CHECK-SAME: i64
+
+// -----
+
+// Test `!fir.tdesc` conversion.
+
+func private @foo0(%arg0: !fir.tdesc<!fir.type<x>>)
+// CHECK-LABEL: foo0
+// CHECK-SAME:  !llvm.ptr<i8>
+
+func private @foo1(%arg : !fir.tdesc<!fir.array<100xf32>>)
+// CHECK-LABEL: foo1
+// CHECK-SAME:  !llvm.ptr<i8>
+
+func private @foo2(%arg : !fir.tdesc<f32>)
+// CHECK-LABEL: foo2
+// CHECK-SAME:  !llvm.ptr<i8>
+
+func private @foo3(%arg : !fir.tdesc<!fir.type<derived7{f1:f32,f2:f32}>>)
+// CHECK-LABEL: foo3
+// CHECK-SAME:  !llvm.ptr<i8>
Index: flang/lib/Optimizer/CodeGen/TypeConverter.h
===================================================================
--- flang/lib/Optimizer/CodeGen/TypeConverter.h
+++ flang/lib/Optimizer/CodeGen/TypeConverter.h
@@ -87,6 +87,9 @@
     addConversion([&](fir::SequenceType sequence) {
       return convertSequenceType(sequence);
     });
+    addConversion([&](fir::TypeDescType tdesc) {
+      return convertTypeDescType(tdesc.getContext());
+    });
     addConversion([&](fir::VectorType vecTy) {
       return mlir::VectorType::get(llvm::ArrayRef<int64_t>(vecTy.getLen()),
                                    convertType(vecTy.getEleTy()));
@@ -280,6 +283,14 @@
     return mlir::LLVM::LLVMPointerType::get(baseTy);
   }
 
+  // fir.tdesc<any>  -->  llvm<"i8*">
+  // TODO: For now use a void*, however pointer identity is not sufficient for
+  // the f18 object v. class distinction (F2003).
+  mlir::Type convertTypeDescType(mlir::MLIRContext *ctx) {
+    return mlir::LLVM::LLVMPointerType::get(
+        mlir::IntegerType::get(&getContext(), 8));
+  }
+
   /// Convert llvm::Type::TypeID to mlir::Type
   mlir::Type fromRealTypeID(llvm::Type::TypeID typeID, fir::KindTy kind) {
     switch (typeID) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113769.387171.patch
Type: text/x-patch
Size: 1993 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211115/62058229/attachment.bin>


More information about the llvm-commits mailing list