[PATCH] D113733: [llvm-objdump/mac] Add support for new load commands

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added subscribers: smeenai, alexander-shaposhnikov.
jhenderson added a comment.
This revision is now accepted and ready to land.

This looks fine to me, but I am not a Mach-O developer, so someone with more experience should sign off on it too (@alexander-shaposhnikov, @smeenai?)



================
Comment at: llvm/test/tools/llvm-objdump/MachO/Inputs/chained-fixups.yaml:1
+--- !mach-o
+FileHeader:
----------------
Do you have multiple tests planned that will use this input file? If not, keep it with the test case you've added to llvm-objdump.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/lc-chained-fixups.test:1
+RUN: yaml2obj %p/Inputs/chained-fixups.yaml > %t
+RUN: llvm-objdump -p %t | FileCheck %s
----------------
It's more common in newer test cases (at least the ones I work on) to use the inlined edit.

The main advantage is that when copying this line into PowerShell (something I do sometimes when debugging tests), I don't end up with weirdness around encoding (PowerShell `>` performs UTF-16 encoding).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113733/new/

https://reviews.llvm.org/D113733