[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 00:00:46 PST 2021


thevinster added inline comments.


================
Comment at: lld/Common/Args.cpp:29
 
+OptimizationLevel args::getOptLevel(llvm::opt::InputArgList &args,
+                                    unsigned int key,
----------------
nit: `getOptLevel` seems a bit too generic for something that's LTO specific. The MachO port has the concept of passing an opt level that generates more efficient opcodes. Suggestions are welcome here - perhaps `getLTOOptLevel` would be better here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113738/new/

https://reviews.llvm.org/D113738



More information about the llvm-commits mailing list