[PATCH] D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 14 23:52:23 PST 2021


djtodoro added a comment.

Thanks!



================
Comment at: llvm/docs/InstrRefDebugInfo.md:82
+
+# LiveDebugValues
+
----------------
I think this can have a `see also` referring to the https://llvm.org/docs/SourceLevelDebugging.html#livedebugvalues-expansion-of-variable-locations.


================
Comment at: llvm/docs/InstrRefDebugInfo.md:143
+
+  %2:gr32 ADD32rr %0, %1, debug-instr-number 1
+
----------------
nit: are we missing a `=` here? (and below)


================
Comment at: llvm/docs/InstrRefDebugInfo.md:169
+Should your target clone instructions, much the same as the TailDuplicator
+optimisation pass,, do not attempt to preserve the instruction numbers or
+record any substitutions. MachineFunction::CloneMachineInstr should drop the
----------------
double `;;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113586/new/

https://reviews.llvm.org/D113586



More information about the llvm-commits mailing list