[PATCH] D113475: [llvm-tblgen][RISCV] Make llvm-tblgen RISCVCompressInstEmitter to be common infra across different targets

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 14 19:23:34 PST 2021


zixuan-wu added inline comments.


================
Comment at: llvm/include/llvm/Target/Target.td:663-674
+/// Defines a Pat match between compressed and uncompressed instruction.
+/// The relationship and helper function generation are handled by
+/// CompressInstEmitter backend.
+class CompressPat<dag input, dag output, list<Predicate> predicates = []> {
+  /// Uncompressed instruction description.
+  dag Input = input;
+  /// Compressed instruction description.
----------------
jrtc27 wrote:
> Most of these comments don't make sense to me. Especially isCompressOnly's.
Anymore specific suggestion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113475/new/

https://reviews.llvm.org/D113475



More information about the llvm-commits mailing list