[PATCH] D113798: Add loop unrolling and peeling preferences for RISCV

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:146
+
+for.body:                                         ; preds = %entry, %for.body
+  %indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
----------------
This comment is still there


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:163
+
+!0 = distinct !{!0, !1}
+!1 = !{!"llvm.loop.mustprogress"}
----------------
!0 is only used self-referentially; only !1 is referenced from outside of the metadata itself. So I don't think this distinct does anything.


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:164
+!0 = distinct !{!0, !1}
+!1 = !{!"llvm.loop.mustprogress"}
----------------
Is this needed (same for the !llvm.loop)? If yes, just inline it like !llvm.loop, if no delete them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113798/new/

https://reviews.llvm.org/D113798