[PATCH] D108261: [DebugInfo] Fix end_sequence of debug_line in LTO Object

Kyungwoo Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 14 09:45:14 PST 2021


kyulee updated this revision to Diff 387101.
kyulee added a comment.

Terminate the line table aligning with Range creation:

- When a new range is formed due to section or CU change
- When nodebug function starts
- When module is finished

>From the above, I think the line table is well-formed in DwarfDebug (normal compiler path).
No need specialization for asm streamer or object stremer to end the line table.

However, the MC path seems to still terminate using the section end symbol conservatively,
because we do not track the range like the DwarfDebug path as above.
So, I still preserve `emitDwarfLineEndEntry` when no end entry is emitted in the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108261/new/

https://reviews.llvm.org/D108261

Files:
  llvm/include/llvm/MC/MCDwarf.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
  llvm/lib/MC/MCDwarf.cpp
  llvm/test/DebugInfo/XCOFF/empty.ll
  llvm/test/DebugInfo/XCOFF/explicit-section.ll
  llvm/test/DebugInfo/XCOFF/function-sections.ll
  llvm/test/DebugInfo/debugline-endsequence.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108261.387101.patch
Type: text/x-patch
Size: 15046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211114/ddd41b23/attachment.bin>


More information about the llvm-commits mailing list