[PATCH] D113192: [DAG] MatchRotate - support rotate-by-constant of illegal types

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/vector-rotate-128.ll:2402-2403
 ; AVX512F-NEXT:    vpand {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0, %xmm0
-; AVX512F-NEXT:    vpand {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm1, %xmm1
-; AVX512F-NEXT:    vpor %xmm0, %xmm1, %xmm0
 ; AVX512F-NEXT:    retq
----------------
lebedev.ri wrote:
> So we exchanged this or + and-by-folded-load for constant pool load + vpternlogq ?
Yes, that was what we went with for D113827 as a base implementation - D113845 will improve broadcast folds for ternlog


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113192/new/

https://reviews.llvm.org/D113192