[PATCH] D113798: Add loop unrolling and peeling preferences for RISCV

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt %s -S -mtriple=riscv64-unknown-linux-gnu -loop-unroll | FileCheck %s
+
----------------
Use -mtriple=riscv64 unless it's genuinely OS-dependent (which this is not)


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:4
+
+define dso_local void @saxpy(float %a, float* noalias nocapture readonly %x, float* noalias nocapture %y) {
+; CHECK-LABEL: @saxpy(
----------------
I doubt you need all these pointer attributes


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:146
+
+for.cond.cleanup:                                 ; preds = %for.body
+  ret void
----------------
These comments do nothing


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:146
+
+for.cond.cleanup:                                 ; preds = %for.body
+  ret void
----------------
jrtc27 wrote:
> These comments do nothing
This would also be more natural as the final block in the function; presumably the current block schedule is an artefact of the order in which various optimisation happened on the original C and IR


================
Comment at: llvm/test/Transforms/LoopUnroll/RISCV/unroll.ll:163
+
+!4 = !{!5, !5, i64 0}
+!5 = !{!"float", !6, i64 0}
----------------
Is the TBAA actually needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113798/new/

https://reviews.llvm.org/D113798