[PATCH] D113192: [DAG] MatchRotate - support rotate-by-constant of illegal types (WIP)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/vector-rotate-128.ll:2410
+; AVX512F-NEXT:    vpand {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0, %xmm0
 ; AVX512F-NEXT:    retq
 ;
----------------
RKSimon wrote:
> This seems to be the last regression - we fold (and (shift x, c1), c2) but fail to do the same for (and (rotate x, c1), c2)
This can be better handled with improved VPTERNLOG generation: D113827


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113192/new/

https://reviews.llvm.org/D113192