[PATCH] D113782: [SLP]Improve cost model for the shuffled extracts.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5287
     // to detect it as a final shuffled/identity match.
-    if (EU.User && isa<InsertElementInst>(EU.User)) {
+    if (isa_and_nonnull<InsertElementInst>(EU.User)) {
       if (auto *FTy = dyn_cast<FixedVectorType>(EU.User->getType())) {
----------------
Pull out this NFC?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5300
+          // Go through of insertelement instructions trying to find either VU
+          // as the original vector for IE2 or V as the original vector for IE1.
           do {
----------------
Pull out this NFC?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5392
+    APInt CombinedDemandedElts(MaxVF, 0);
+    CombinedDemandedElts |= DemandedElts.front().zextOrSelf(MaxVF);
+    auto *VecTy = FixedVectorType::get(
----------------
Why perform the OR with zero?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113782/new/

https://reviews.llvm.org/D113782