[PATCH] D113774: [SLP]Improve splat detection.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:261
+  Value *FirstNonUndef = nullptr;
+  for (unsigned I = 0, E = VL.size(); I < E; ++I) {
+    if (isa<UndefValue>(VL[I]))
----------------
for-range loop?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:271
+  }
   return true;
 }
----------------
Should we accept all undef cases? The comment says 'some'.
```
return FirstNonUndef != nullptr;

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113774/new/

https://reviews.llvm.org/D113774