[lld] 51715fb - [lld-macho] Fix warning

Keith Smiley via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 19:39:50 PST 2021


Author: Keith Smiley
Date: 2021-11-12T19:36:51-08:00
New Revision: 51715fbd96c100e08ad5e0afe78eff474e4caa3f

URL: https://github.com/llvm/llvm-project/commit/51715fbd96c100e08ad5e0afe78eff474e4caa3f
DIFF: https://github.com/llvm/llvm-project/commit/51715fbd96c100e08ad5e0afe78eff474e4caa3f.diff

LOG: [lld-macho] Fix warning

```
/Users/ksmiley/dev/llvm-project/lld/MachO/Symbols.cpp:43:27: warning: field 'external' will be initialized after field 'weakDefCanBeHidden' [-Wreorder-ctor]
      weakDef(isWeakDef), external(isExternal),
                          ^
1 warning generated.
```

Differential Revision: https://reviews.llvm.org/D113823

Added: 
    

Modified: 
    lld/MachO/Symbols.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/Symbols.cpp b/lld/MachO/Symbols.cpp
index 7b04d2512f67..ed9b4d6383ad 100644
--- a/lld/MachO/Symbols.cpp
+++ b/lld/MachO/Symbols.cpp
@@ -40,8 +40,8 @@ Defined::Defined(StringRefZ name, InputFile *file, InputSection *isec,
       overridesWeakDef(canOverrideWeakDef), privateExtern(isPrivateExtern),
       includeInSymtab(true), thumb(isThumb),
       referencedDynamically(isReferencedDynamically), noDeadStrip(noDeadStrip),
-      weakDef(isWeakDef), external(isExternal),
-      weakDefCanBeHidden(isWeakDefCanBeHidden) {
+      weakDefCanBeHidden(isWeakDefCanBeHidden), weakDef(isWeakDef),
+      external(isExternal) {
   if (isec) {
     isec->symbols.push_back(this);
     // Maintain sorted order.


        


More information about the llvm-commits mailing list