[PATCH] D113823: [lld-macho] Fix warning

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 19:26:43 PST 2021


keith created this revision.
keith added a reviewer: oontvoo.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
keith requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

  /Users/ksmiley/dev/llvm-project/lld/MachO/Symbols.cpp:43:27: warning: field 'external' will be initialized after field 'weakDefCanBeHidden' [-Wreorder-ctor]
        weakDef(isWeakDef), external(isExternal),
                            ^
  1 warning generated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113823

Files:
  lld/MachO/Symbols.cpp


Index: lld/MachO/Symbols.cpp
===================================================================
--- lld/MachO/Symbols.cpp
+++ lld/MachO/Symbols.cpp
@@ -40,8 +40,8 @@
       overridesWeakDef(canOverrideWeakDef), privateExtern(isPrivateExtern),
       includeInSymtab(true), thumb(isThumb),
       referencedDynamically(isReferencedDynamically), noDeadStrip(noDeadStrip),
-      weakDef(isWeakDef), external(isExternal),
-      weakDefCanBeHidden(isWeakDefCanBeHidden) {
+      weakDefCanBeHidden(isWeakDefCanBeHidden), weakDef(isWeakDef),
+      external(isExternal) {
   if (isec) {
     isec->symbols.push_back(this);
     // Maintain sorted order.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113823.387000.patch
Type: text/x-patch
Size: 651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211113/df303b77/attachment.bin>


More information about the llvm-commits mailing list