[PATCH] D113819: [llvm-obcopy][MachO] Add error for MH_PRELOAD

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 17:48:53 PST 2021


alexander-shaposhnikov added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/Inputs/mh_preload.yaml:1
+--- !mach-o
+FileHeader:
----------------
this can be reduced to just the header, no load commands, no sections


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:396
+  if (O->get()->Header.FileType == MachO::HeaderFileType::MH_PRELOAD)
+    return createStringError(std::errc::invalid_argument,
+                             "%s: MH_PRELOAD files are not supported",
----------------
if I am not mistaken this should be replaced with llvm::errc::not_supported


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113819/new/

https://reviews.llvm.org/D113819



More information about the llvm-commits mailing list