[PATCH] D113167: [lld-macho]Allow exporting weak_def_can_be_hidden(AKA "autohide") symbols

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:102-103
       isPrivateExtern, isThumb, isReferencedDynamically, noDeadStrip);
   defined->overridesWeakDef = overridesWeakDef;
+  defined->weakDefCanBeHidden = isWeakDefCanBeHidden;
   return defined;
----------------
int3 wrote:
> I forgot why we chose not to have `overridesWeakDef` as part of the Defined constructor... is it very ugly to add an additional optional param instead of doing this assignment?
good question - dunno why it was written this way.
so make both of them optional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113167/new/

https://reviews.llvm.org/D113167