[PATCH] D113813: [MachO] Reduce size of Symbol and Defined

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 17:35:34 PST 2021


smeenai added a comment.

In D113813#3128878 <https://reviews.llvm.org/D113813#3128878>, @oontvoo wrote:

> In D113813#3128715 <https://reviews.llvm.org/D113813#3128715>, @smeenai wrote:
>
>> This will cause merge conflicts for D113167 <https://reviews.llvm.org/D113167>. I'm happy to wait until that lands, if @oontvoo prefers.
>>
>> I'll move the asserts to Symbols.cpp if I get positive responses to https://reviews.llvm.org/D113809#3128636.
>
> Thanks! Does anyone want to LGTM D113167 <https://reviews.llvm.org/D113167> ? :)
>
> Otherwise, since your patch seems less controversial, feel free to ship it .. I can resolve the conflicts afterwards - didn't seem like a big one (I think)

I'm not planning to land mine till Monday, and looks like you have your LGTM, so feel free to commit ahead of me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113813/new/

https://reviews.llvm.org/D113813



More information about the llvm-commits mailing list