[PATCH] D113818: [MachO] Shrink reloc from 32 bytes to 24 bytes

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D113818#3128844 <https://reviews.llvm.org/D113818#3128844>, @int3 wrote:

>> from 7.85 MB to 7.64 MB
>
> I think you meant GB :)

Hah, fixed.



================
Comment at: lld/MachO/InputFiles.cpp:355
+template <class T>
+static InputSection *findContainingSubsection(SubsectionMap &map, T *offset) {
   auto it = std::prev(llvm::upper_bound(
----------------
int3 wrote:
> hm, can't we leave it as uint64_t and have the uint32_t be automatically promoted?
Promotion doesn't happen for pointer arguments (you wouldn't wanna write 8 bytes into a 4 byte storage slot).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113818/new/

https://reviews.llvm.org/D113818