[PATCH] D113809: [MachO] Fix struct size assertion

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 15:15:43 PST 2021


smeenai added a comment.

How do people feel about moving asserts like this into the corresponding source files (InputSection.cpp) instead of the headers? It's nice to keep the assert close to the definition, but it also causes errors to be emitted from every single source file including the header (I got 21 separate errors when I fixed the size check without updating the size, for example).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113809/new/

https://reviews.llvm.org/D113809



More information about the llvm-commits mailing list