[PATCH] D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes

[Scott Linder via Phabricator via llvm-commits]

scott.linder added reviewers: tejohnson, alexfh.
scott.linder added a comment.

In D104827#3128572 <https://reviews.llvm.org/D104827#3128572>, @scott.linder wrote:

> Update DIArgList::handleChangedOperand to propagate in-place changes which
> would require the DIArgList become distinct up to the owning MetadataAsValue.
>
> This feels a bit odd, but so does allowing DIArgList to be `distinct` as an
> implementation detail, while never serializing that fact (and so making a
> round-trip lossy). Semantically this may be OK, but unless we have a good
> reason not to I feel like finding a way to ensure these "inline" nodes are
> always uniqued will make the relationship between IR/bitcode and the in-memory
> representation more obvious.

I'm adding some more reviewers from those involved in https://reviews.llvm.org/D108968, as I'm essentially extending the changes made there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104827/new/

https://reviews.llvm.org/D104827