[PATCH] D113800: [amdgpu] Don't crash on empty global ctor/dtor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-empty-ctor-dtor.ll:1
+; RUN: opt -S -mtriple=amdgcn--  -amdgpu-lower-ctor-dtor < %s | FileCheck %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 -filetype=obj -o - < %s | llvm-readelf -s - 2>&1 | FileCheck %s
----------------
I don't see what this opt line is accomplishing with the checks. Needs some positive IR checks?


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-empty-ctor-dtor.ll:2
+; RUN: opt -S -mtriple=amdgcn--  -amdgpu-lower-ctor-dtor < %s | FileCheck %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 -filetype=obj -o - < %s | llvm-readelf -s - 2>&1 | FileCheck %s
+
----------------
Why disassemble instead of directly emit text?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113800/new/

https://reviews.llvm.org/D113800