[PATCH] D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added a comment.

In D96914#3128270 <https://reviews.llvm.org/D96914#3128270>, @MaskRay wrote:

> `-Wreserved-identifier` which is not in -Wall/-Wextra catches exactly this.

I wrote "[...] a patch to clang to issue a hard error whenever [...]" for a reason. `-Wreserved-identifier` does not do that, and I hope that you agree it would be absurd to change it to be enabled by other flags (except `-Weverything`), let alone promoted to an error, no matter what the C and C++ standards say: that would break things that we make work by design and we want to keep working, things that from LLVM POV are valid, including use of `__start_*`. (It also does not catch exactly the same cases that I described, but the details are irrelevant to this issue.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96914/new/

https://reviews.llvm.org/D96914