[PATCH] D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 12:10:30 PST 2021


jrtc27 added a comment.

In D96914#3128151 <https://reviews.llvm.org/D96914#3128151>, @hvdijk wrote:

> In D96914#3128137 <https://reviews.llvm.org/D96914#3128137>, @jrtc27 wrote:
>
>> What the warning suggests as a fix is entirely TBD; can suggest any and all of source, codegen and linker flag changes
>
> I meant that implementing what you proposed would result in a warning in cases where my thinking is there should be no warning at all, so was hoping would be a way of detecting those cases and suppressing the warning for those cases. I wasn't thinking about what the warning would say.

Oh you mean the case where people do want things that look like linker sets to be GC'ed. Those cases could always explicitly opt in, or just ignore the warnings. I don't think there's a good answer to that (otherwise we'd use that exact same logic to determine which behaviour to use in the first place...).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96914/new/

https://reviews.llvm.org/D96914



More information about the llvm-commits mailing list