[PATCH] D113577: [SCEV] Support rewriting ZExt expressions with loop guard info.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.



In D113577#3127923 <https://reviews.llvm.org/D113577#3127923>, @reames wrote:

> Thanks for the rebase, much easier to understand.
>
> LGTM w/the previous inline style comment addressed.  You can follow up on the fixed point question post-commit if desired.

Thanks! I still need to construct a couple of test cases for the follow-up. But I thought a bit more and I think I need maintain a vector with expressions to rewrite separately, to avoid depending on the iteration order of the dense map, which may not be consistent. I'm planning to incorporate that in the commit version, independent of following up on the fixed-point iteration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113577/new/

https://reviews.llvm.org/D113577