[PATCH] D111447: [Dexter] Add DexDeclareAddress command and address function

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/address_printing.cpp:6-9
+//
+//      Note: Currently "misordered result" is the only penalty that does not
+//      display the address properly; if it is implemented, this test should be
+//      updated.
----------------
Orlando wrote:
> I don't think it should block the feature either way but I'm curious about why this is? 
The short summary is that the misordered result array is constructed by a function that does not trivially convert to the address/resolution logic; at least, that was my assessment when I looked at it - I'll take another look before merging to see if it isn't actually reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111447/new/

https://reviews.llvm.org/D111447