[PATCH] D113577: [SCEV] Support rewriting ZExt expressions with loop guard info.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 386885.
fhahn marked an inline comment as done.
fhahn added a comment.

In D113577#3127717 <https://reviews.llvm.org/D113577#3127717>, @reames wrote:

> This generally looks very reasonable.
>
> Can I request that you split off the change which switches the map from value keyed to SCEV keyed, and land that without separate review?  It seems like it should be entirely NFC.  Reducing diff and isolating failures is always good.

Thanks, I committed the SCEV->SECV map change in 03cfea68c65f <https://reviews.llvm.org/rG03cfea68c65f02ad4267a2b026fe5baf32a2d519> and rebased the patch.

I'll respond to the inline comments in a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113577/new/

https://reviews.llvm.org/D113577

Files:
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info-rewrite-expressions.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113577.386885.patch
Type: text/x-patch
Size: 5651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211112/d4acfa6d/attachment.bin>