[PATCH] D113652: [DebugInfo][test] Simplify/imporove a few tests using --impicit-check-not=DW_TAG. NFC

Fri Nov 12 10:23:42 PST 2021

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Fair - I think the c11 test is better with the name query form. -your choice on the other one.

================
Comment at: llvm/test/DebugInfo/X86/align_cpp11.ll:81-84
+; CHECK:   DW_TAG_pointer_type
+; CHECK:   DW_TAG_base_type
+; CHECK:   DW_TAG_pointer_type
+; CHECK:   DW_TAG_const_type
----------------
krisb wrote:
> dblaikie wrote:
> > Any chance some filtering could be done to avoid checking a bunch of other tags in this test? 
> This test checks almost all entities from the dump, so filtering by name doesn't do much for it. Will update for comparing.
> 
Fair enough - yeah, maybe in future tests we can intentionally name the relevant entities to make them easy to match by name, but for this one I agree it's probably more name queries than is especially helpful. It is nice that this makes the test less dependent on the structure of the rest of the DWARF (eg: if we change the order that basic types get emitted for whatever reason - the name-query based version of the test is resilient to that in a way that the check-all-tags form is not)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113652/new/

https://reviews.llvm.org/D113652