[PATCH] D112573: [IndVarSimplify] Reduce nondeterministic behaviour in visitIVCast.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 12 10:10:25 PST 2021
reames added a comment.
Surely this causes some test diff in the existing test corpus? It looks like the review is incomplete. (Or I'm simply very surprised.)
Under the assumption the diff is incomplete, I'd suggest a slightly more complicate heuristic. Pick signed or unsigned based on which we see more of. Simply keep two counters, pick the larger, and tie break when equal towards sign.
If there actually no other diffs, you can ignore previous. I just find that slightly hard to believe. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112573/new/
https://reviews.llvm.org/D112573
More information about the llvm-commits
mailing list